Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaleway_lb: simplify function logic #9189

Merged
merged 2 commits into from
Nov 25, 2024
Merged

scaleway_lb: simplify function logic #9189

merged 2 commits into from
Nov 25, 2024

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Nov 25, 2024

SUMMARY

Simplify return for the function lb_attributes_should_be_changed().

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

scaleway_lb

@ansibullbot
Copy link
Collaborator

cc @abarbare @remyleone
click here for bot help

@ansibullbot ansibullbot added module module plugins plugin (any type) small_patch Hopefully easy to review labels Nov 25, 2024
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Nov 25, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch and removed check-before-release PR will be looked at again shortly before release and merged if possible. labels Nov 25, 2024
@felixfontein felixfontein merged commit b498308 into ansible-collections:main Nov 25, 2024
129 checks passed
@patchback Patchback
Copy link

patchback bot commented Nov 25, 2024 •
edited
Loading

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/b49830861cfbba4d513ef61a832440f20e11aaef/pr-9189

Backported as #9196

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Nov 25, 2024
@russoz @patchback
scaleway_lb: simplify function logic (#9189)
aee0518 
* scaleway_lb: simplify function logic

* add changelog frag

(cherry picked from commit b498308)
@patchback patchback bot mentioned this pull request Nov 25, 2024
Merged
@russoz russoz deleted the scaleway-lb-simplify-return branch November 25, 2024 20:49
felixfontein pushed a commit that referenced this pull request Nov 26, 2024
@patchback @russoz
[PR #9189/b4983086 backport][stable-10] scaleway_lb: simplify functio…
4152770 
…n logic (#9196)

scaleway_lb: simplify function logic (#9189)

* scaleway_lb: simplify function logic

* add changelog frag

(cherry picked from commit b498308)

Co-authored-by: Alexei Znamensky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-10 Automatically create a backport for the stable-10 branch module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein